Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cache] Don't erase processed redis dsn #29543

Merged
merged 1 commit into from Dec 10, 2018
Merged

[Cache] Don't erase processed redis dsn #29543

merged 1 commit into from Dec 10, 2018

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Dec 9, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@chalasr chalasr added this to the 4.2 milestone Dec 9, 2018
@fabpot
Copy link
Member

fabpot commented Dec 10, 2018

Thank you @chalasr.

@fabpot fabpot merged commit 7b2a337 into symfony:4.2 Dec 10, 2018
fabpot added a commit that referenced this pull request Dec 10, 2018
@fabpot
bug #29543 [Cache] Don't erase processed redis dsn (chalasr)
fae1854 
This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] Don't erase processed redis dsn

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

7b2a337 [Cache] Fix dsn parsing
@chalasr chalasr deleted the cache-redis-dsn branch December 10, 2018 08:26
@fabpot fabpot mentioned this pull request Jan 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chalasr @fabpot @nicolas-grekas @carsonbot